[ast-developers] "builtin_cd.sh" test module... / was: Re: /dev/file/flags@xattr@/dev/fd/$n no longer works in ast-ksh.2013-09-26 ...

[Roland Mainz]

The following code from one of my test scripts no longer work in
-- snip --
[Invalid argument]
-- snip --

[snip]

So basically we're back the point where the whole code within |#if
O_XATTR| doesn't work... and shouldn't be used because the
implementations will perform horribly performance-wise.

What is wrong with the following patch to fix the original problem
that $ ksh -c 'redirect {n}<. ; redirect
-- snip --
diff -r -u original/src/lib/libast/path/pathopen.c
build_i386_64bit_debug/src/lib/libast/path/pathopen.c
--- src/lib/libast/path/pathopen.c 2013-08-29 07:17:52.000000000 +0200
+++ src/lib/libast/path/pathopen.c 2013-09-27 08:03:03.149006810 +0200
@@ -222,7 +222,7 @@
/* preserve open() semantics if possible */
- if (oflags & (O_DIRECTORY|O_SEARCH))
+ if (oflags & (O_DIRECTORY|O_SEARCH|O_XATTR))
return openat(dev.fd, ".",
oflags|O_INTERCEPT, mode);
#if O_XATTR
if ((f = openat(dev.fd, ".",
O_INTERCEPT|O_RDONLY|O_XATTR)) >= 0)
-- snip --
Looking at the output of "truss" it seems to do exactly what's
requested at shell code level...

BTW: Attached (as "builtin_cd.sh.gz") is the test module I'm using to
verify the cd -@ functionality...

... note that I'm going to split the XATTR /dev/flags@ and getconf(1)
parts into a new test module because they are far beyond the scope of
the plain cd(1) tests...

----

Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL [phone]
(;O/ \/ \O;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: builtin_cd.sh.gz
Type: application/x-gzip
Size: 3336 bytes
Desc: not available
URL: <http://lists.research.att.com/pipermail/ast-developers/attachments/20130927/3c24fa18/attachment-0001.gz>