[ast-developers] [patch] Patch for |O

Discussion:

[ast-developers] [patch] Patch for |O_search| ...

Roland Mainz

2013-05-05 20:13:42 UTC

Attached (as "astopen_o_search_001.diff.txt") is a prototype patch for
ast-open.2012-08-24 to get |O_search| defined (e.g. it's either
pointing to POSIX's |O_SEARCH|, Linux's |O_PATH| or is not defined)
and _used_ ...
... the bug problem with it is... it works on Solaris+AIX (which both
have |O_SEARCH|) ... but it does not work on Linux unless I compile
ast-open with $ (CC='gcc -D_GNU_SOURCE=1' nice ksh ./bin/package make)
#. The problem is that |O_PATH| is only defined if |_GNU_SOURCE| is
set... and something seems to undefine it somehow in the sources
unless it's set globally for all source files...
Glenn: Can you have a look, please ?

Attached (as "astksh20130503_use_o_path_as_o_search001.diff.gz") is a
fully working version of the patch.

Notes:
- Please keep the Linux-specific #error ASSERT in
src/lib/libast/features/fcntl.c intact... it took some time to figure
out that the Linux includes have issues with |_GNU_SOURCE| vs.
|_USE_GNU| and I don't want to hunt such "ghost bugs" in that area
again

----

Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: astksh20130503_use_o_path_as_o_search001.diff.gz
Type: application/x-gzip
Size: 2365 bytes
Desc: not available
URL: <http://lists.research.att.com/pipermail/ast-developers/attachments/20130505/b4d56cd9/attachment.gz>

Roland Mainz

2013-05-08 00:31:39 UTC

Permalink

Post by Roland Mainz

Attached (as "astksh20130503_use_o_path_as_o_search001.diff.gz") is a
fully working version of the patch.
- Please keep the Linux-specific #error ASSERT in
src/lib/libast/features/fcntl.c intact... it took some time to figure
out that the Linux includes have issues with |_GNU_SOURCE| vs.
|_USE_GNU| and I don't want to hunt such "ghost bugs" in that area
again

Erm... ping !? Did you get the patch or was it lost in the
ast-developers@ mailman outage ?

----

Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: astksh20130503_use_o_path_as_o_search001.diff.gz
Type: application/x-gzip
Size: 2365 bytes
Desc: not available
URL: <http://lists.research.att.com/pipermail/ast-developers/attachments/20130508/d2b2aca3/attachment.gz>

Roland Mainz

2013-05-09 22:47:26 UTC

Permalink

Post by Roland Mainz

Erm... ping !? Did you get the patch or was it lost in the

2nd try since it seems the patch didn't make it through the list... ;-((

----

Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: astksh20130503_use_o_path_as_o_search001.diff.gz
Type: application/x-gzip
Size: 2365 bytes
Desc: not available
URL: <http://lists.research.att.com/pipermail/ast-developers/attachments/20130510/f15912fd/attachment-0001.gz>

ольга крыжановская

2013-06-12 14:52:52 UTC

Permalink

Glenn, this patch was still not applied to ast-ksh.2013-06-11. Why?

Olga

Post by Roland Mainz

Erm... ping !? Did you get the patch or was it lost in the

2nd try since it seems the patch didn't make it through the list... ;-((
----
Bye,
Roland
--
__ . . __
(o.\ \/ /.o) roland.mainz at nrubsig.org
\__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer
/O /==\ O\ TEL +49 641 3992797
(;O/ \/ \O;)
_______________________________________________
ast-developers mailing list
ast-developers at lists.research.att.com
http://lists.research.att.com/mailman/listinfo/ast-developers

--
, _ _ ,
{ \/`o;====- Olga Kryzhanovska -====;o`\/ }
.----'-/`-/ olga.kryzhanovska at gmail.com \-`\-'----.
`'-..-| / http://twitter.com/fleyta \ |-..-'`
/\/\ Solaris/BSD//C/C++ programmer /\/\
`--` `--`