Discussion:
[ast-developers] iffe change broke some tests
Michal Hlavinka
2013-11-12 10:37:23 UTC
Permalink
Hi,

I've found that iffe change between 2013-08-07 and 2013-08-14 broke some
tests. The problem is in execute() function. It added extra
argument $tmp.u
13-08-11 iffe.sh: axecuted blocks now have a sungle argument that is a
tmp file prefix

But some tests do not like it. For example vfork test in ksh. With this
change it returns
iffe: test: vfork exists and it works ... no
instead of 'yes'.
The vfork test executes itself and uses argv[1] non-existance as switch.

...
if (argv[1])
_exit(signal(SIGHUP, SIG_DFL) != SIG_IGN);
...
execv(cmd[0], cmd);
...

With the iffe change, argv[1] exists even in first execution and test
does not work correctly.

This is just one test I've found, but there may be other tests that
won't work with the iffe change.

Michal
Glenn Fowler
2013-11-12 19:29:37 UTC
Permalink
thanks for the report
this will be fixed this week
Post by Michal Hlavinka
Hi,
I've found that iffe change between 2013-08-07 and 2013-08-14 broke some
tests. The problem is in execute() function. It added extra
argument $tmp.u
13-08-11 iffe.sh: axecuted blocks now have a sungle argument that is a tmp
file prefix
But some tests do not like it. For example vfork test in ksh. With this
change it returns
iffe: test: vfork exists and it works ... no
instead of 'yes'.
The vfork test executes itself and uses argv[1] non-existance as switch.
...
if (argv[1])
_exit(signal(SIGHUP, SIG_DFL) != SIG_IGN);
...
execv(cmd[0], cmd);
...
With the iffe change, argv[1] exists even in first execution and test does
not work correctly.
This is just one test I've found, but there may be other tests that won't
work with the iffe change.
Michal
_______________________________________________
ast-developers mailing list
ast-developers at lists.research.att.com
http://lists.research.att.com/mailman/listinfo/ast-developers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.research.att.com/pipermail/ast-developers/attachments/20131112/6bf9210b/attachment.html>
Irek Szczesniak
2013-11-13 12:50:26 UTC
Permalink
Post by Glenn Fowler
thanks for the report
this will be fixed this week
When *exactly* are you planning to make a new release?

Irek

Loading...