[ast-developers] Small bug in sh_checkaudit() of src/cmd/ksh93/edit/history.c

[Dr. Werner Fink]

HI,

I've seen this line

if((fd=open(name, O_RDONLY,O_cloexec)) < 0)

in sh_checkaudit() .. maybe the colon should become a pipe character.

Werner
--
"Having a smoking section in a restaurant is like having
a peeing section in a swimming pool." -- Edward Burr
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: not available
URL: <http://lists.research.att.com/pipermail/ast-developers/attachments/20131011/b8654501/attachment.sig>

[Glenn Fowler]

thanks Werner
after s/colon/comma/ it makes sense
also, the ast build now provides O_CLOEXEC so the line should be

if ((fd = open(name, O_RDONLY|O_CLOEXEC) < 0)

Post by Dr. Werner Fink
HI,
I've seen this line
if((fd=open(name, O_RDONLY,O_cloexec)) < 0)
in sh_checkaudit() .. maybe the colon should become a pipe character.
Werner
--
"Having a smoking section in a restaurant is like having
a peeing section in a swimming pool." -- Edward Burr
_______________________________________________
ast-developers mailing list
ast-developers at lists.research.att.com
http://lists.research.att.com/mailman/listinfo/ast-developers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.research.att.com/pipermail/ast-developers/attachments/20131011/a3ac77f0/attachment.html>